Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corpus Module Cleanup #19

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Corpus Module Cleanup #19

wants to merge 11 commits into from

Conversation

Olamyy
Copy link
Contributor

@Olamyy Olamyy commented Dec 15, 2019

Took sometime to rework the corpus module.
Major changes:

  1. Introduced a corpus and corpus path getter.
  2. A simple yaml file for keeping tracks of available datasets.

@ruohoruotsi
Copy link
Member

This one is also broken, let me look at both of them and see if there isn't some meta-pattern we can adopt to facilitate a smoother PR process. I know this is painful for the Travis to be so disagreeable.

Also we might consider adopting GitHub Actions in the future, as a better CI/CD system

@Olamyy
Copy link
Contributor Author

Olamyy commented Dec 18, 2019

Yeah. They both break at the same point.

I added some txt and yaml files that some functions depend on. However, it doesn't seem like travis copies those when it installs the package. It's a packaging issue. I've added the paths to Manifest.in like you did for the model but that still doesn't work. I've also tried adding the paths to package_dir and data_files in setup but still, the same thing.

@ruohoruotsi
Copy link
Member

no problem, working on it now ... will try some things locally, and save tests via pushes to Travis for when I'm fresher in the AM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants